-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port delay re-draw fix #10
Open
otcathatsya
wants to merge
5
commits into
INM-6:main
Choose a base branch
from
otcathatsya:port_delay_fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
otcathatsya
commented
Apr 10, 2024
•
edited
Loading
edited
- Reference for delay change: The cortical microcircuit NEST examples do not generate the number of connections with a minimal delay that one might expect nest/nest-simulator#2503
- This was fixed in the NEST-local example a while back but seemingly not updated elsewhere
- Note: This was also applied to MAM now and also needs to be re-re-ported to NEST master
otcathatsya
changed the title
Port delay re-draw fix
Port microcircuit delay re-draw fix
Apr 10, 2024
otcathatsya
changed the title
Port microcircuit delay re-draw fix
Port delay re-draw fix
Jun 19, 2024
otcathatsya
force-pushed
the
port_delay_fix
branch
from
June 19, 2024 09:10
913ccd6
to
f3c7a46
Compare
mlober
requested changes
Jun 19, 2024
mlober
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Catherine. This looks good to me now.
ackurth
reviewed
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for the changes :)
ackurth
approved these changes
Jun 21, 2024
Bump on merging this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.